Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated onFrameProcessed to include processed frame in the callback #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IhorPeresunko
Copy link
Contributor

@IhorPeresunko IhorPeresunko commented May 6, 2024

Description of changes

Fix to Issue 68.

A lot of use cases need to have audio chunks before user stops talking. To solve this I extended the onFrameProcesses callback to include processed frame, which can be used on the library-user side to concat/play/do whatever.

Checklist

  • Added a test to verify that changes work as expected (if one doesn't exist already)
  • Ran automated tests successfully
  • Viewed manual test site and verified that pages are working
  • Bumped versions in relevant packages
  • Updated relevant changelogs

@ricky0123
Copy link
Owner

Hi @IhorPeresunko thanks for this, I'm going to try to take a closer look soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants