Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main with sqlfluff main #2

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Update main with sqlfluff main #2

merged 3 commits into from
Oct 12, 2021

Conversation

myschkyna
Copy link

@myschkyna myschkyna commented Oct 12, 2021

Firstly, thanks for adding this feature! Secondly, please check the key steps against the checklist below to make your contribution easy to merge.

Please give the Pull Request a meaningful title (including the dialect this PR is for if it is dialect specific), as this will automatically be added to the release notes, and then the Change Log.

Brief summary of the change made

If there is an open issue for this, then please include fixes #XXXX or closes #XXXX replacing XXXX with the issue number and it will automatically close the issue when the pull request is merged. Alternatively if not fully closed you can say makes progress on #XXXX to create a link on that issue without closing it.
...

Are there any other side effects of this change that we should be aware of?

...

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

myschkyna and others added 3 commits October 12, 2021 08:27
* Fixes for using inline dollar signs for identifiers

* Add tests

* Remove accidentally committed class

* Remove the correct accidentally commited class

* Fixes
* FIx broken block comments in exasol

* Allow adding a global test config per testcase

* Respect config per testcase

* Allow adding a global test config per testcase

* Respect config per testcase

* add testcase

* make unittest description more meaningful

Co-authored-by: Alan Cruickshank <alanmcruickshank@gmail.com>
Co-authored-by: Barry Pollard <barry@tunetheweb.com>
@myschkyna myschkyna merged commit af3e34e into ridefelyx:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants