Adds an EventBuilder to dissociate the DSL/builder from the client #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this PR, i also want to be able to construct events without relying on a RiemannClient. |
|
@aphyr I am broadly +1 with test coverage but am not a regular user of the client. Do you have any thoughts? |
|
I've added more tests and fixed a bug. The |
mcorbin
reviewed
Oct 16, 2017
| // health -> good | ||
| assertEquals("health", eventAttributes.get(2).getKey()); | ||
| assertEquals("good", eventAttributes.get(2).getValue()); | ||
| // health -> good |
There was a problem hiding this comment.
Nice catch.
Actually I don't think these comments are really useful, I will remove them.
|
LGTM |
|
@jamtur01 Ok to merge this PR ? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EventDSLis useful but at the same time the class is tightly coupled with the RiemannClient and the constructor is usingjava.net.InetAddress.getLocalHost()(which can make call to the DNS resolver... see #44).Also in our context, we have a dedicated host that send events to Riemann (so the call to
java.net.InetAddress.getLocalHost()is useless).Using the low-level builder
Proto.Event.newBuilder()as an alternative is a bit rough (at least for a newcomer).As a result I've decided to create a new class named
EventBuilderwho's only job is to ease the creation of anEvent. To avoid code duplication,EventDSLis usingEventBuilder.This change does not introduce a breaking change since the API of the
EventDSLremains the same.I've started to write one unit test (and I planned to write more and also add documentation) but before spending more time on it, I would like to hear from you. Are you OK with this change ?