New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Clojure 1.11.1 #1039
Update to Clojure 1.11.1 #1039
Conversation
Recent versions of Clojure changed to throw a CompilerException if macroexpansion fails. The RuntimeException thrown by riemann.test/tap is now the cause.
Dang, CI does not currently run on PRs. I opened #1040 to address this issue. |
I don't think I can manually trigger a GH action on the branch - if you push an update it should run. |
I am not sure that closing / reopening the PR will do the trick (since the branch has no CI bits). I think that rebasing on top of
Thanks! |
Thank you for the quick change to get CI running on PRs! That's great. I synced my fork with this repo, and that has triggered CI on the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 馃挴
And me! Thanks for this! 馃憤 |
#1038
Update Clojure version to 1.11.1 in project.clj.
Initially, this caused a test to fail:
The
riemann.test/tap
macro throws a RuntimeException if a tap with the given name already exists:riemann/src/riemann/test.clj
Lines 64 to 69 in 25235d3
Clojure changed how errors in macroexpansion are reported - it's now a CompilerException with the original RuntimeException as a cause, so the assertion needs to pull out the
ex-cause
.I ran tests locally by mimicking the steps in
.github/workflows/test.yaml
. If there's a way to run the Gtihub test workflow on this PR, that would be great! 馃檹