Also run the test suite on PR #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have CI running when code is pushed to the riemann repository. For external contribution, this only happen when a PR is merged, but detecting issues earlier is advisable. Instead of running CI when code is pushed in any branch of the repo, run CI when the main branch is updated, and when a PR targeting the main branch is updated. Signed-off-by: Romain Tartière <romain@blogreen.org>
|
Thanks @smortex - there was a reason for this in the dim dark past, but I cannot remember what it is so ... yolo. :) |
|
I guess it can be used by cryptobro to mine some cryptocrap and be quickly banned from GitHub 🤷 … I have experienced some org that have tuned what happen when new contributors send their first PR: https://github.com/orgs/community/discussions/14334 I see there are option in Settings > Actions > General > Fork pull request workflows from outside collaborators, I have not changed the default but maybe you can check these? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have CI running when code is pushed to the riemann repository. For
external contribution, this only happen when a PR is merged, but
detecting issues earlier is advisable.
Instead of running CI when code is pushed in any branch of the repo, run
CI when the main branch is updated, and when a PR targeting the main
branch is updated.