Skip to content

Commit

Permalink
Merge pull request #100 from tauffredou/fix-s3-cache
Browse files Browse the repository at this point in the history
Fix s3 cache section
  • Loading branch information
riemers committed Feb 8, 2020
2 parents d45a571 + 6bda94a commit 5c9659b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tasks/update-config-runner.yml
Expand Up @@ -130,7 +130,7 @@
dest: "{{ temp_runner_config.path }}"
regexp: '^\s*\[runners\.cache\.s3\]'
line: ' [runners.cache.s3]'
state: "{{ 'present' if gitlab_runner.cache_s3_server_address is defined else 'absent' }}"
state: "{{ 'present' if gitlab_runner.cache_type == 's3' else 'absent' }}"

This comment has been minimized.

Copy link
@riemers

riemers Feb 12, 2020

Author Owner

If this was changed to "is defined" it would not break. Just putting a note down.

insertafter: '^\s*\[runners\.cache\]'
backrefs: no
check_mode: no
Expand Down Expand Up @@ -225,6 +225,7 @@
backrefs: no
check_mode: no
notify: restart_gitlab_runner
when: gitlab_runner.cache_type == 's3'

- name: Set cache s3 bucket location option
lineinfile:
Expand Down Expand Up @@ -260,6 +261,7 @@
backrefs: no
check_mode: no
notify: restart_gitlab_runner
when: gitlab_runner.cache_type == 'gcs'

- name: Set cache gcs credentials file
lineinfile:
Expand Down Expand Up @@ -351,7 +353,6 @@
check_mode: no
notify: restart_gitlab_runner


- name: Set builds dir file option
lineinfile:
dest: "{{ temp_runner_config.path }}"
Expand Down

0 comments on commit 5c9659b

Please sign in to comment.