Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s3 cache section #100

Merged
merged 2 commits into from Feb 8, 2020
Merged

Fix s3 cache section #100

merged 2 commits into from Feb 8, 2020

Conversation

tauffredou
Copy link
Contributor

@tauffredou tauffredou commented Feb 5, 2020 •
edited

This PR fixes s3 section in config.toml

  • set cache_s3_server_address as optional and generate runners.cache.s3 when cache is s3. The default server is AWS s3.
  • mutex the "BucketName" tasks as both gcs and s3 use "^\s*BucketName" regexp

@tauffredou
Fix runners.cache.s3 section
771d801 
s3 and gcs cache sections both "haveBucketName" directive.
Either "Set cache s3 bucket name option" or "Set cache gcs bucket name"
can be run or the gcs task will override the s3 config.
@tauffredou
Add runners.cache.s3 section when cache_type is s3
6bda94a
@riemers riemers merged commit 5c9659b into riemers:master Feb 8, 2020
@riemers
Copy link
Owner

riemers commented Feb 12, 2020 •
edited

Hey @tauffredou could you take another look, since it has now turned into a mandatory setting. See #101

@tauffredou
Copy link
Contributor Author

Hey @tauffredou could you take another look, since it has now turned into a mandatory setting.

Hi what do you mean? Has the spec changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tauffredou @riemers