static commands: fix parameter passing (in async commands) #1170
Conversation
exyi
force-pushed
the
bug/parameter-lambda-static-command-services
branch
from
206c416
to
228cf5d
Compare
| @@ -351,7 +351,7 @@ public DataSourceLengthBinding GetDataSourceLength(ParsedExpressionBindingProper | |||
| } | |||
|
|
|||
|
|
|||
| public StaticCommandJsAstProperty CompileStaticCommand(DataContextStack dataContext, ParsedExpressionBindingProperty expression) => | |||
| public StaticCommandJsAstProperty CompileStaticCommand(DataContextStack dataContext, CastedExpressionBindingProperty expression) => | |||
There was a problem hiding this comment.
This is actually one of the more important changes - the CastedExpression is automatically wrapped in a lambda function unless it's already a delegate. We already have this logic for commands, now we also use it for static commands
| @@ -154,7 +154,7 @@ export async function applyPostbackHandlers( | |||
|
|
|||
| try { | |||
| const commit = await applyPostbackHandlersCore(saneNext, options, handlers); | |||
| const result = await commit(...args); | |||
| const result = await commit(); | |||
There was a problem hiding this comment.
We were passing arguments through the commit function, which should not even be used in static commands 🤦 I'm surprised it did not create any magic problems with postback handlers
exyi
changed the title
The parameters were passed in a very weird way, now it works similar to command bindings - even when command is not a lambda function, it is wrapped in a lambda function. Then, the lambda function gets parameters assigned directly, so the lambda syntax is essentially eliminated. This back and forth is kinda needed to align how it works in case command is specified as plain expression and when it's specified as lambda function. resolves #980, #1165
exyi
force-pushed
the
bug/parameter-lambda-static-command-services
branch
from
228cf5d
to
ca2ab8a
Compare
quigamdev
requested review from
acizmarik and
quigamdev
and removed request for
acizmarik
…static-command-services
src/Framework/Framework/Compilation/Javascript/JsPrettificationVisitor.cs
Outdated
Show resolved
Hide resolved
| @@ -49,6 +49,10 @@ public static Expression Replace(LambdaExpression ex, params Expression[] parame | |||
|
|
|||
| #region Replace overloads | |||
|
|
|||
| public static Expression Replace<TRes>(Expression<Func<TRes>> ex) | |||
There was a problem hiding this comment.
Although it is not really in scope of this PR, I think that ReplaceVisitor is not that good name. From this method it is not clear what gets replaced. If I understood correctly it patches stubs and replaces parameters. To me it looks more like a "method patching visitor" or something.
Might be worth refactoring if we can come up with a more descriptive name both for the visitor and for these methods.
We will try to unwrap the result so it does not contain DotvvmAfterPostbackArgs
The parameters were passed in a very weird way, now it works similar
to command bindings - even when command is not a lambda function, it is
wrapped in a lambda function. Then, the lambda function gets parameters
assigned directly, so the lambda syntax is essentially eliminated.
This back and forth is kinda needed to align how it works in case command
is specified as plain expression and when it's specified as
lambda function.
resolves #980