Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static commands: fix parameter passing (in async commands) #1170

Merged
merged 6 commits into from
Oct 20, 2021
Merged

static commands: fix parameter passing (in async commands) #1170

merged 6 commits into from
Oct 20, 2021

Commits on Oct 16, 2021

  1. Added sample for lambda parameters passed to static command services

    @tomasherceg @exyi
    tomasherceg authored and exyi committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    6c8f0a0 View commit details
    Browse the repository at this point in the history

  2. static commands: fix parameter passing (in async commands) 

    The parameters were passed in a very weird way, now it works similar
to command bindings - even when command is not a lambda function, it is
wrapped in a lambda function. Then, the lambda function gets parameters
assigned directly, so the lambda syntax is essentially eliminated.
This back and forth is kinda needed to align how it works in case command
is specified as plain expression and when it's specified as
lambda function.

resolves  #980, #1165
    @exyi
    exyi committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    ca2ab8a View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Merge remote-tracking branch 'origin/main' into bug/parameter-lambda-… 

    …static-command-services
    @exyi
    exyi committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    744c8a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. static commands: fix small things from code review

    @exyi
    exyi committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    77a10a3 View commit details
    Browse the repository at this point in the history

  2. Fix problem with delegate conversion if result is already a delegate

    @exyi
    exyi committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    1e305e9 View commit details
    Browse the repository at this point in the history

  3. Fix return value from named command 

    We will try to unwrap the result so it does not contain
DotvvmAfterPostbackArgs
    @exyi
    exyi committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    f5765b9 View commit details
    Browse the repository at this point in the history