Added child memoization to Repeater and fixed initialization bug #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controls are rendered twice on postback - OnLoad to find the command and OnPreRender to give controls chance to render anything they need. With this patch, the repeater will not reinitialize the controls that were already initialized in Load and their DataContext was not changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controls are rendered twice on postback - OnLoad to find the command
and OnPreRender to give controls chance to render anything they need.
With this patch, the repeater will not reinitialize the controls that
were already initialized in Load and their DataContext was not changed.
EDIT: I did not mention what was the bugfix about:
The problem was, that on GET request in client-side rendering the server-side control tree was only initialized in Load. So when you had control that depended on being server-side initialized, your dataset was loaded in PreRender and Repeater was in Client rendering, your control was only initialized as client-side template which caused unexpected behavior.