Add rewrite_arithmetic handler #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braised-babbage
force-pushed
the
feature/rewrite-arithmetic-natively
branch
from
7cbaf9d
to
94662cf
Compare
braised-babbage
force-pushed
the
feature/rewrite-arithmetic-natively
branch
from
bb13f39
to
cd4a332
Compare
notmgsk
approved these changes
May 4, 2020
| @@ -8,6 +8,9 @@ Changelog | |||
|
|
|||
| ### Improvements and Changes | |||
|
|
|||
| - Added a PyQuil only `rewrite_arithmetic` handler, deprecating the previous | |||
There was a problem hiding this comment.
don't h8, hyphenate
pyquil-only
pyquil/tests/test_api.py
Outdated
Comment on lines
402
to
411
| assert ( | ||
| response.quil | ||
| == Program( | ||
| "DECLARE __P2 REAL[2]", | ||
| "DECLARE theta REAL[1]", | ||
| "DECLARE beta REAL[1]", | ||
| "RZ(__P2[0]) 0", | ||
| "RZ(__P2[1]) 0", | ||
| ).out() | ||
| ) |
There was a problem hiding this comment.
i don't make the rules!
kalzoo
approved these changes
May 5, 2020
pyquil/tests/test_api.py
Outdated
| @@ -343,3 +350,62 @@ def test_local_conjugate_request(benchmarker): | |||
| def test_apply_clifford_to_pauli(benchmarker): | |||
| response = benchmarker.apply_clifford_to_pauli(Program("H 0"), PauliTerm("I", 0, 0.34)) | |||
| assert response == PauliTerm("I", 0, 0.34) | |||
|
|
|||
|
|
|||
| def test_rewrite_arithmetic_no_params(): | |||
There was a problem hiding this comment.
Do you think these could live in api/test_rewrite_arithmetic.py?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When compiling native quil programs, the first step is to do "arithmetic rewriting", which turns compound gate parameters into simple memory references. The motivation for this is that the underlying hardware can do a certain amount of arithmetic, but not everything (multiplication and division are done via arithmetic shifts, and so are restricted to powers of two, also real arithmetic is done with fixed point numbers which results in a loss of precision, and so on).
This arithmetic rewriting is actually quite simple, but presently requires a call to the quilc client. This is a bit annoying, as
native_quil_to_executabledoes not otherwise need quilc, and in my personal experience this dependency can be a bit burdensome when developing/testingnative_quil_to_executablefunctionality. This PR deprecates this call with a simple and explicitrewrite_arithmeticfunction.In the long term we will need to reconsider entirely this approach (if we are to allow for run-time updates to parameter values), but for now this is how things are.
Checklist
flake8conventions.