Use native Gate.dagger() in Program.dagger() #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmgsk
requested review from
stevenheidel,
stylewarning,
karalekas and
ecpeterson
stylewarning
approved these changes
Apr 18, 2019
ecpeterson
reviewed
Apr 24, 2019
|
It looks like there are open review comments here. |
karalekas
reviewed
May 16, 2019
notmgsk
force-pushed
the
fix/use-native-dagger
branch
from
66538f4
to
13062df
Compare
|
@notmgsk Semaphore seems upset only because this branch doesn't incorporate the parser change that tolerates quilc emitting tabs. |
This removes a bunch of logic around creating inverse gates from user-defined gates. If anyone thinks that stuff is useful, then I would argue that it should be in some util function, not in Program.dagger(). Kept kw args for backwards compat :(
notmgsk
force-pushed
the
fix/use-native-dagger
branch
from
13062df
to
25a0c4d
Compare
ecpeterson
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a bunch of logic around creating inverse gates from
user-defined gates. If anyone thinks that stuff is useful, then I
would argue that it should be in some util function, not in
Program.dagger().
Kept kw args for backwards compat :(