Integrating the animation from POC with the app #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maniramezan
reviewed
Oct 1, 2021
Comment on lines
1
to
5
| import React, { useState, useRef } from "react"; | ||
| import { StyleSheet, Text, View, Image, Animated } from "react-native"; | ||
| import { scale } from "react-native-size-matters"; | ||
| import LinearGradient from "react-native-linear-gradient"; | ||
| import * as Progress from "react-native-progress"; |
There was a problem hiding this comment.
nit: For consistency would be nice not to have ; at the end.
maniramezan
reviewed
Oct 1, 2021
maniramezan
reviewed
Oct 1, 2021
maniramezan
reviewed
Oct 1, 2021
maniramezan
reviewed
Oct 1, 2021
| marginBottom: scale(4), | ||
| } | ||
| }) | ||
| container: { |
There was a problem hiding this comment.
Looks like your tabs are at 2space so it shows all the lines as changed instead of the newly added ones
There was a problem hiding this comment.
Yup I have made it to be 4 now
maniramezan
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an animation to show voting page to show the updates from chosen answers by teams
After conversations with the UI team, it was decided that the whole review questions flow should be one screen and hence the review page was removed from the application
animation.mp4