js課題8 作成しました！ #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.js
Outdated
| @@ -4,8 +4,8 @@ | |||
| // 1. 掃除 | |||
| // 2. 買い物 | |||
| // 3. 散歩 | |||
| // ここに変数「todos」を用意する | |||
|
|
|||
| // ここに変数「todo」を用意する | |||
There was a problem hiding this comment.
todos で間違っていいないような気がしますが、todoに変更した理由は何でしょうか？
main.js
Outdated
| // ここに変数「todos」を用意する | ||
|
|
||
| // ここに変数「todo」を用意する | ||
| todos = ['1.掃除', '2.買い物', '3.散歩']; |
There was a problem hiding this comment.
初めて使う変数の場合はconstかletを使うようにしてください。
main.js
Outdated
| @@ -15,10 +15,11 @@ | |||
| // 3. 削除 | |||
| // 4. 終了 | |||
| // ここに変数「commands」を用意する | |||
| commands = ['確認', '追加', '削除', '終了']; | |||
There was a problem hiding this comment.
main.js
Outdated
| console.log('========================'); | ||
| console.log('現在持っているのタスク一覧'); | ||
| console.log('========================'); | ||
| if(todos.length < 0) { |
There was a problem hiding this comment.
ここの条件がおかしくなっているので、todosの確認をしても常に1件も表示されなあいようになっています。
(現状の実装だとtodos配列の中身が0件未満であればifの中が実行されるようになっています。)
main.js
Outdated
| @@ -71,6 +96,17 @@ | |||
| * 3. showTodos関数を実行して、現在保持しているタスク一覧を表示する | |||
| */ | |||
| // ここにcreateTodo関数を作る | |||
| function createTodo() { | |||
| todo = prompt('タスクを入力してください'); | |||
There was a problem hiding this comment.
main.js
Outdated
| @@ -93,4 +129,14 @@ | |||
| * 3. showTodos関数を実行して、現在保持しているタスク一覧を表示する | |||
| */ | |||
| // ここにdeleteTodo関数を作る | |||
|
|
|||
| function deleteTodo() { | |||
| NumberString = prompt('削除するタスクの番号を指定してください'); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
また変数名は小文字から始めるが一般的です。
(先頭大文字のキャメルケースはクラスに、全て大文字は定数として使われるのが一般的です。)
main.js
Outdated
|
|
||
| function deleteTodo() { | ||
| NumberString = prompt('削除するタスクの番号を指定してください'); | ||
| parsedNumber = parseInt(NumberString,10); |
There was a problem hiding this comment.
|
いろいろとコメントしたのでご確認お願いしますmm |
|
👍 OKです^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
レビューお願いします！