Implement new parser, close #382, close #332

[ice1000]

No, description, provided.

But please do add more tests to ensure that originally-accepted Haskell pragmas are still accepted in this new version.

[ice1000]

Also please check that if it breaks any completion/linting features. The AST is changed.

[rikvdkleij]

@ice1000

Many thanks! Your help is great!

But please do add more tests to ensure that originally-accepted Haskell pragmas are still accepted in this new version.

I will do my best 😄

Also please check that if it breaks any completion/linting features. The AST is changed.

Will so some more testing.

[rikvdkleij]

@ice1000
Hmm, somethings goes wrong.

When I try to enter a pragma the syntax highlighting for the whole file does weird and I can not remove tokens in the pragma.

Can you take a look?

[ice1000]

Sounds like some real tests are needed apart from test cases.
I'll check it right now.

[rikvdkleij]

Thanks!

Sounds like some real tests are needed apart from test cases.

It looks your change broke some features but I have no problem with fixing that if parser and bnf are correctly working.

Also the handler which automatically enters the closing pragma is broken. I think because the pragma is now defined in the parser.
I think you forgot something because in the flex file still OPTIONS_GHC is defined while it's now in general for pragma's.

[ice1000]

I've digged a little and it sounds like it's more rubost

[rikvdkleij]

@ice1000

FYI, this change broke automatically closing double quotes, fixed in 65ee527

[ice1000]

Again?
Oh no..

[ice1000]

Ah. I thought it's an unused lex fule. I'm sorry

[rikvdkleij]

@ice1000

No problem 😄 Just FYI.