Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background Images Issues #6

Open
MentalGear opened this issue Jun 27, 2016 · 3 comments
Open

Background Images Issues #6

MentalGear opened this issue Jun 27, 2016 · 3 comments

Comments

@MentalGear
Copy link

MentalGear commented Jun 27, 2016 •
edited
Loading

Don't get me wrong: I really like the minimalism Dark Theme turns some websites into by obliterating some unnecessary background images - but some sites that consist almost entirely of bg images for context (I'm looking at you Apple.com) or other websites with background images for container elements (change.org) lose functionality when the extension is turned on.

Any thoughts on how to counter this ?
@rileyjshaw rileyjshaw mentioned this issue Jun 28, 2016
Closed
@rileyjshaw
Copy link
Owner

I'm unsure how to solve this reliably. For Apple's website I'm in favor of blocking the background image. You lose some information, but I'd rather not show a bright white image (and one of the initial goals of this project was to not need to invert images... ugly). Well-designed, accessible websites shouldn't keep semantic information in a background image so hopefully this won't be a huge problem...

The button thing is a huge problem and I'd love to find a solution for it. Perhaps we could show background images on <button> or role="button" elements? There may be serious contrast violations for buttons that are designed to be on a light background 😣 ...but it's better than showing nothing.

That's one "solution", but it has problems. Only targeting container elements like <html> or <body> as you mentioned in #3 is another. I've thought about this a fair bit and haven't come up with a good general solution. Are you interested in giving it a shot?

@Eonasdan
Copy link

I'm assuming this issue on youtube is related:
image

@Eonasdan
Copy link

some weirdness in Inbox as well

image

@Eonasdan Eonasdan mentioned this issue Feb 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Eonasdan @rileyjshaw @MentalGear