Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add deadzone for handling for over-active x/y analog inputs #35

Conversation

ianclawson
Copy link

Like the comment in the actual code says:

// Handle edge case where some physcial controllers' (like Xbox) analog sticks report both x/y inputs incredibly granularly,
// resulting in an inability to use the analog stick for only a single directional input at a time, such as in place of a d-pad.
// TODO: ideally this would be a user-configurable threshold, but DeltaCore doesn't currently support configurable settings.

This is similar to #17 , although this implementation is 'deeper' in the controller call stack. For the controllers I tested with, the implementation in #17 didn't work for every screen that handles game controller input -- such as the controller mapping screen -- whereas this implementation works system-wide.

This PR might also not solve every use case that #17 solves. Testing would be appreciated.

@ianclawson ianclawson changed the title Chore: add handling for over-active x/y analog inputs Chore: add deadzone for handling for over-active x/y analog inputs Nov 19, 2021
@ianclawson
Copy link
Author

Closing this to clean up my work list of Open PRs

@ianclawson ianclawson closed this Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant