Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tsc checks to filter by file and TS error code #4172

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

bcolloran
Copy link
Contributor

@bcolloran bcolloran commented Feb 26, 2024

Updating the whitelist script to check by file and TS code. This will prevent newTS errors from entering the codebase unless there is already an error with the same error code in the updated file. The whitelist can be gradually tightened as the codebase improves.

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ericpgreen2 ericpgreen2 merged commit 7c1304e into main Feb 26, 2024
1 check passed
@ericpgreen2 ericpgreen2 deleted the tsc-checks-by-file-and-code branch February 26, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants