Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix list builder #47

Merged
merged 3 commits into from Nov 24, 2021
Merged

Feature/fix list builder #47

merged 3 commits into from Nov 24, 2021

Conversation

vitoke
Copy link
Contributor

@vitoke vitoke commented Nov 24, 2021

Fixes #46

@codecov-commenter
Copy link

Codecov Report

Merging #47 (857d32d) into main (4184e49) will increase coverage by 0.40%.
The diff coverage is 73.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   82.97%   83.37%   +0.40%     
==========================================
  Files         222      224       +2     
  Lines       14673    14681       +8     
  Branches     2492     2493       +1     
==========================================
+ Hits        12175    12241      +66     
+ Misses       2414     2356      -58     
  Partials       84       84              
Impacted Files Coverage Δ
packages/list/src/builder/tree/tree-builder.ts 21.51% <0.00%> (-3.36%) ⬇️
packages/list/src/interface.ts 75.00% <ø> (ø)
...ges/stream/src/async-stream/async-stream-source.ts 100.00% <ø> (ø)
packages/stream/src/stream/stream-source.ts 100.00% <ø> (ø)
packages/list/src/builder/leaf/tree-builder.ts 64.93% <64.93%> (ø)
packages/list/src/builder/gen-builder.ts 93.22% <80.00%> (-0.75%) ⬇️
packages/common/src/async-optlazy.ts 100.00% <100.00%> (ø)
packages/list/src/context.ts 92.79% <100.00%> (+1.80%) ⬆️
packages/list/src/list-custom.ts 100.00% <100.00%> (ø)
packages/stream/src/async-stream/constructors.ts 91.27% <100.00%> (+0.02%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c321aa3...857d32d. Read the comment docs.

@vitoke vitoke merged commit ff61366 into main Nov 24, 2021
@vitoke vitoke deleted the feature/fix-list-builder branch November 24, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Builder mixes up order for large Lists
2 participants