Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve security by adding Object.freeze to global objects and l… #73

Merged
merged 1 commit into from
May 14, 2022

Conversation

vitoke
Copy link
Contributor

@vitoke vitoke commented May 14, 2022

…ocal singletons

Fixes #72

@codecov-commenter
Copy link

Codecov Report

Merging #73 (426277d) into main (1eeeaf0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files          56       56           
  Lines        4439     4439           
  Branches      458      456    -2     
=======================================
  Hits         3783     3783           
  Misses        568      568           
  Partials       88       88           
Impacted Files Coverage Δ
packages/common/src/reducer.ts 17.62% <ø> (ø)
packages/common/src/traverse-state.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33dd7ca...426277d. Read the comment docs.

@vitoke vitoke merged commit 84baeda into main May 14, 2022
@vitoke vitoke deleted the feature/improve-security branch May 14, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent prototype pollution for static imports and singleton objects
2 participants