Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a regression in reverse_lookup_filter introduced in #699 #701

Merged
merged 2 commits into from Sep 3, 2023
Merged

Fix a regression in reverse_lookup_filter introduced in #699 #701

merged 2 commits into from Sep 3, 2023

Conversation

ksqsf
Copy link
Contributor

@ksqsf ksqsf commented Sep 3, 2023

Pull request

Issue tracker

Reported by @eagleoflqj ; Fix a regression introduced by #699

#699 mistakenly assumed at least one of append_comment and overwrite_comment is true, and will break the old behavior. This PR fixes this.

Sorry for my mistake :(

Feature

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@ksqsf ksqsf marked this pull request as ready for review September 3, 2023 05:55
@eagleoflqj
Copy link
Member

Changed the logic a bit.

seq overwrite append empty e825f7d fd1a6dc
0 0 0 0 return early return early
1 0 0 1 overwrite overwrite
2 0 1 0 append append
3 0 1 1 append overwrite
4-7 1 ? ? overwrite overwrite

The only difference with your commit is when !overwrite && append && empty, I think in this case better not adding a extraneous space.

@eagleoflqj eagleoflqj merged commit 8af548f into rime:master Sep 3, 2023
6 checks passed
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
@ksqsf @eagleoflqj @groverlynn
Fix a regression in reverse_lookup_filter introduced in rime#699 (rim…
b010f0c 
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@ksqsf @eagleoflqj @graphemecluster
Fix a regression in reverse_lookup_filter introduced in rime#699 (rim…
8e18f98 
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@ksqsf @eagleoflqj @graphemecluster
Fix a regression in reverse_lookup_filter introduced in rime#699 (rim…
81f3751 
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@ksqsf @eagleoflqj @graphemecluster
Fix a regression in reverse_lookup_filter introduced in rime#699 (rim…
e9a88cf 
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksqsf @eagleoflqj