Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow reverse_lookup_filter to append new codes to existing comments #699

Merged
merged 1 commit into from Sep 2, 2023
Merged

feat: Allow reverse_lookup_filter to append new codes to existing comments #699

merged 1 commit into from Sep 2, 2023

Conversation

ksqsf
Copy link
Contributor

@ksqsf ksqsf commented Sep 2, 2023 •
edited

Pull request

Issue tracker

None

Feature

Allows reverse_lookup_filter to append new information to existing comments, instead of just ignoring or overwriting them. Before this PR, the user has to discard some information when the comment and the new codes are not empty.

This PR introduces a new option append_comment, akin to the existing overwrite_comment.

  • If append_comment is true, the newly found codes are appended to the existing comments (separated with a space).
  • If both append_comment and overwrite_comment are true, overwrite_comment takes priority, ie. the existing comments are discarded.

Unit test

  • Done

Not sure where to put the test? I'd be happy to add tests, should there be any guidance.

Manual test

  • Done
image

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@ksqsf ksqsf marked this pull request as ready for review September 2, 2023 13:09
@ksqsf ksqsf changed the title add append_comment to reverse_lookup_filter feat: Allow reverse_lookup_filter to append new codes to existing comments Sep 2, 2023
lotem
lotem approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@lotem lotem merged commit f079c3c into rime:master Sep 2, 2023
6 checks passed
@ksqsf ksqsf mentioned this pull request Sep 3, 2023
Merged
2 tasks
eagleoflqj added a commit that referenced this pull request Sep 3, 2023
@ksqsf @eagleoflqj
Fix a regression in reverse_lookup_filter introduced in #699 (#701)
8af548f 
---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
@ksqsf @groverlynn
feat: add append_comment option to reverse_lookup_filter (rime#699)
a71a8f6 
Allow reverse_lookup_filter to append new codes to existing comments
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
@ksqsf @eagleoflqj @groverlynn
Fix a regression in reverse_lookup_filter introduced in rime#699 (rim…
b010f0c 
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@ksqsf @graphemecluster
feat: add append_comment option to reverse_lookup_filter (rime#699)
56320a7 
Allow reverse_lookup_filter to append new codes to existing comments
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@ksqsf @eagleoflqj @graphemecluster
Fix a regression in reverse_lookup_filter introduced in rime#699 (rim…
8e18f98 
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@ksqsf @graphemecluster
feat: add append_comment option to reverse_lookup_filter (rime#699)
9522090 
Allow reverse_lookup_filter to append new codes to existing comments
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@ksqsf @eagleoflqj @graphemecluster
Fix a regression in reverse_lookup_filter introduced in rime#699 (rim…
81f3751 
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
@mirtlecn mirtlecn mentioned this pull request Feb 2, 2024
Open
2 tasks
@shewer shewer mentioned this pull request Feb 19, 2024
Closed
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@ksqsf @graphemecluster
feat: add append_comment option to reverse_lookup_filter (rime#699)
ce17218 
Allow reverse_lookup_filter to append new codes to existing comments
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@ksqsf @eagleoflqj @graphemecluster
Fix a regression in reverse_lookup_filter introduced in rime#699 (rim…
e9a88cf 
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksqsf @lotem