Allow interpuncts in phrases #776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groverlynn
force-pushed
the
interpuncts
branch
from
74dd54f
to
2a2d2f8
Compare
|
This feature should not be added as a hidden behaviour. There are input schemas which do encode symbols. Consider creating a separate tool for editing code in the yaml dictionary. |
groverlynn
force-pushed
the
interpuncts
branch
2 times, most recently
from
ecfda1b
to
52961a2
Compare
just revised as you suggested |
groverlynn
force-pushed
the
interpuncts
branch
from
52961a2
to
2c7c43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Allow certain interpuncts in phrases in dictionaries. Essay already has some of them in the entries but disabled for now.
This allows easier input of transliterated names (e.g. 尚－雅克‧盧梭 or 让‐雅克·卢梭, with the same code as 尚雅克盧梭 or 让雅克卢梭), disambiguation names (刚果（金）, with the same code as 刚果金), and poem verses (e.g. 鵝，鵝，鵝，曲項向天歌, with the same code as 鵝鵝鵝曲項向天歌)
Setting in dictionary:
encoder/free_punctsThe value is one single string containing all of the intended free punctuations (can include any characters, not necessarily punctuations).
The default value is
·‧‐－，（）(U+00B7 middle dot, U+2027 hyphenation point, U+2010 hyphen, U+FF0D fullwidth hyphen-minus, U+FF0C fullwidth comma, U+FF08 fullwidth left parenthesis, U+FF09 fullwidth right parenthesis). Use the default free puncts, setencoder/free_punctsto "default" or "preset". To opt-out, set the value to an empty string ("")Unit test
Manual test
Code Review
Additional Info