fix(SquirrelPanel): use of uninitialized local variable linear, vertical

maybe fixes #513 #513 can sometimes be reproduced by using Squirrel after: rm ~/Library/Rime/build/squirrel.yaml; Squirrel --quit
rime · Feb 13, 2021 · e8b87a4 · e8b87a4 · GJRobert · Feb 17, 2021
1 parent 655209a
commit e8b87a4
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/SquirrelPanel.m b/SquirrelPanel.m
@@ -1278,8 +1278,8 @@ -(void)loadConfig:(SquirrelConfig *)config forDarkMode:(BOOL)isDark {
 }
 
 +(void)updateTheme:(SquirrelTheme *)theme withConfig:(SquirrelConfig *)config forDarkMode:(BOOL)isDark {
-  BOOL linear;
-  BOOL vertical;
+  BOOL linear = NO;
+  BOOL vertical = NO;
   updateCandidateListLayout(&linear, config, @"style");
   updateTextOrientation(&vertical, config, @"style");
   BOOL inlinePreedit = [config getBool:@"style/inline_preedit"];
@@ -1619,6 +1619,6 @@ +(void)updateTheme:(SquirrelTheme *)theme withConfig:(SquirrelConfig *)config fo
            inlinePreedit:inlinePreedit];
 
   theme.native = isNative;
-  [theme setCandidateFormat: (candidateFormat ? candidateFormat : kDefaultCandidateFormat)];
+  theme.candidateFormat = (candidateFormat ? candidateFormat : kDefaultCandidateFormat);
 }
 @end