feat: add discovery support (#145)

* chore: allow app client secret blank for PKCE * feat: add discovery support * feat: refresh discovery when expired * feat: support retry on initial request error * enhancement: retry when fetch external discovery data error * fix: expired check issue * fix: wrong cache id * fix review issue * fix: remove unused peer deps * fix: wrong ts peer deps * fix karma-ts version issue * chore: add discovery test * fix: test in descri * fix karma test * chore: add tests * fix discovery tests * add discovery tests * chore: add discovery tests
ringcentral · Dec 2, 2020 · a51d7f3 · a51d7f3
1 parent 986b1ad
commit a51d7f3
Show file tree

Hide file tree

Showing 11 changed files with 964 additions and 26 deletions.
diff --git a/demo/src/apiKey.html b/demo/src/apiKey.html
@@ -26,7 +26,7 @@ <h1>
         <div class="panel-body">
 
             <div class="form-group">
-                <label for="appKey" class="col-xs-2 control-label">APP Key</label>
+                <label for="appKey" class="col-xs-2 control-label">App Client Id</label>
 
                 <div class="col-xs-10">
                     <input type="text" class="form-control" id="appKey" placeholder="APP Key" required>
@@ -37,7 +37,7 @@ <h1>
                 <label for="appSecret" class="col-xs-2 control-label">APP Secret</label>
 
                 <div class="col-xs-10">
-                    <input type="text" class="form-control" id="appSecret" placeholder="App Secret" required>
+                    <input type="text" class="form-control" id="appSecret" placeholder="App Client Secret">
                 </div>
             </div>
 
@@ -117,4 +117,4 @@ <h1>
 </script>
 
 </body>
-</html>
+</html>
diff --git a/demo/src/login.html b/demo/src/login.html
@@ -157,7 +157,9 @@ <h1>
         }
 
         function show3leggedLogin({ implicit, usePKCE }) {
-
+            if (!implicit && !usePKCE && !platform._clientSecret) {
+                throw new Error('App Client Secret is required for authorization code flow');
+            }
             platform
                 .loginWindow({
                     url: platform.loginUrl({ implicit, usePKCE })

diff --git a/demo/src/scripts.js b/demo/src/scripts.js
@@ -6,7 +6,7 @@
         var appSecret = localStorage.getItem('ringcentral-demo-appSecret');
         var server = localStorage.getItem('ringcentral-demo-server');
 
-        if (!appSecret || !appKey || !server) {
+        if (!appKey || !server) {
             if (location.href.indexOf('apiKey.html') == -1) {
                 location.assign('apiKey.html');
             }
@@ -39,4 +39,4 @@
 
     };
 
-})();
+})();
diff --git a/redux/package.json b/redux/package.json
@@ -27,7 +27,6 @@
   "peerDependencies": {
     "@ringcentral/sdk": ">=4",
     "react": "*",
-    "react-dom": "*",
     "redux": "*"
   },
   "main": "./lib/index.js",

diff --git a/sdk/src/SDK-spec.ts b/sdk/src/SDK-spec.ts
@@ -2,7 +2,7 @@ import {expect, SDK, spy} from './test/test';
 
 describe('RingCentral.SDK', () => {
     const test = async (suite, server) => {
-        suite.timeout(10000); // Per SLA should be 3 seconds
+        suite.timeout(20000); // Per SLA should be 3 seconds
 
         const sdk = new SDK({
             server,