Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add discovery support #145

Merged
merged 18 commits into from Dec 2, 2020
Merged

feat: add discovery support #145

merged 18 commits into from Dec 2, 2020

Conversation

embbnux
Copy link
Contributor

@embbnux embbnux commented Nov 20, 2020

No description provided.

kirill-konshin
kirill-konshin requested changes Nov 20, 2020
View reviewed changes
sdk/src/platform/Discovery.ts Outdated Show resolved Hide resolved
sdk/src/platform/Discovery.ts Show resolved Hide resolved
@kirill-konshin
Copy link
Contributor

CI needs to be fixed before merge.

@coveralls
Copy link

coveralls commented Nov 30, 2020 •
edited

Coverage Status

Coverage increased (+0.7%) to 90.473% when pulling 37efb2d on embbnux:discovery into 986b1ad on ringcentral:master.

@embbnux
Copy link
Contributor Author

embbnux commented Dec 2, 2020

@kirill-konshin updated to add tests and fix CI

@kirill-konshin kirill-konshin merged commit a51d7f3 into ringcentral:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirill-konshin kirill-konshin kirill-konshin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@embbnux @kirill-konshin @coveralls