Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

me.recentlyPlayed doesn't support parameters, simplifies return data. #30

Closed
nrubin29 opened this issue Feb 13, 2020 · 1 comment
Closed

me.recentlyPlayed doesn't support parameters, simplifies return data. #30

nrubin29 opened this issue Feb 13, 2020 · 1 comment
Labels
bug

Comments

@nrubin29
Copy link
Contributor

nrubin29 commented Feb 13, 2020 •
edited

The me.recentlyPlayed() function doesn't support the limit, before, and after parameters that Spotify supports, and it returns only the tracks, losing the playedAt and context values.

I'm planning to submit a PR soon to fix these issues.
@rinukkusu rinukkusu added the bug label Feb 17, 2020
@rinukkusu
Copy link
Owner

Hi, about your PR, do you still want to follow up on it? Otherwise I can pull in the relevant changes myself, too.

@Loopex2019 Loopex2019 mentioned this issue May 15, 2020
Closed
nrubin29 added a commit to nrubin29/spotify-dart that referenced this issue Jun 20, 2020
@nrubin29
Fixed rinukkusu#30.
a439f33
@nrubin29 nrubin29 changed the title users.recentlyPlayed doesn't support parameters, simplifies return data. me.recentlyPlayed doesn't support parameters, simplifies return data. Jun 20, 2020
rinukkusu added a commit that referenced this issue Oct 12, 2020
@rinukkusu
Merge pull request #66 from nrubin29/master
bc68507 
Improved me.recentlyPlayed() (fixes #30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rinukkusu @nrubin29