Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved me.recentlyPlayed() (fixes #30) #66

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

nrubin29
Copy link
Contributor

@nrubin29 nrubin29 commented Jun 20, 2020

The me.recentlyPlayed() function now supports the limit, before, and after parameters that Spotify supports, and it returns PlayHistory objects, which retain the playedAt and context values.

Copy link
Collaborator

@roisnir roisnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I've added some suggestions, it's pretty much a matter of taste rather than a wrong/correct way, so feel free to change or reject them.

lib/src/endpoints/me.dart Outdated Show resolved Hide resolved
lib/src/endpoints/me.dart Outdated Show resolved Hide resolved
lib/src/endpoints/me.dart Outdated Show resolved Hide resolved
lib/src/endpoints/me.dart Outdated Show resolved Hide resolved
Co-authored-by: Roi Snir <roisnir1@gmail.com>
@rinukkusu rinukkusu merged commit bc68507 into rinukkusu:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants