Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use oauth2 package to support Authorization Code flow #28

Merged
merged 13 commits into from
Feb 14, 2020
Merged

Use oauth2 package to support Authorization Code flow #28

merged 13 commits into from
Feb 14, 2020

Conversation

roisnir
Copy link
Collaborator

@roisnir roisnir commented Feb 6, 2020

I have made some changes and would be happy to get a review.
If I should have stick with the original design or any other change is needed, please tell me.
main changes:

  • The SpotifyApi object can be constructed through Authorization Code flow or Client Credential flow
  • send requests with oauth2 Client to handle authorization instead of requestWrapper
  • implemented _delete
  • reduced SpotifyApi duplicated code on browser and io

rinukkusu
rinukkusu reviewed Feb 10, 2020
View reviewed changes
lib/src/spotify_base.dart Show resolved Hide resolved
lib/src/spotify_browser.dart Show resolved Hide resolved
lib/spotify_browser.dart Outdated Show resolved Hide resolved
@nrubin29 nrubin29 mentioned this pull request Feb 13, 2020
Closed
@rinukkusu rinukkusu merged commit 332f116 into rinukkusu:master Feb 14, 2020
@rinukkusu
Copy link
Owner

LGTM, thank you for the contribution!

@nrubin29 nrubin29 mentioned this pull request Feb 14, 2020
Closed
@roisnir roisnir deleted the use_oauth2_package branch May 15, 2020 16:07
@Loopex2019 Loopex2019 mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinukkusu rinukkusu rinukkusu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roisnir @rinukkusu