Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing projection with static mapper from another assembly #1418

Merged
merged 17 commits into from
Aug 3, 2024
Merged

Fix failing projection with static mapper from another assembly #1418

merged 17 commits into from
Aug 3, 2024

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Jul 26, 2024 •
edited
Loading

Fix failing projection with static mapper from another assembly

Description

A static mapper from another assembly halts the source generator in "IDE" mode. This PR resolves this issue.

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@trejjam trejjam force-pushed the feature/failing-projection-with-static-mapper-from-another-assembly branch 3 times, most recently from f41d395 to efb701c Compare July 26, 2024 09:34
@trejjam
Copy link
Contributor Author

trejjam commented Jul 26, 2024

More context here:
dotnet/roslyn#73964

@trejjam trejjam force-pushed the feature/failing-projection-with-static-mapper-from-another-assembly branch from 6a62492 to 466f18b Compare July 26, 2024 12:05
@latonz latonz added the bug Something isn't working label Aug 3, 2024
latonz
latonz requested changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution! TIL about referenced compilations 😊
I added my feedback, looking forward to get this into main 👍

src/Riok.Mapperly/SyntaxProvider.Roslyn4.0.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly/SyntaxProvider.Roslyn4.0.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly/SyntaxProvider.Roslyn4.4.cs Outdated Show resolved Hide resolved
test/Riok.Mapperly.Tests/Mapping/UseStaticMapperTest.cs Outdated Show resolved Hide resolved
@latonz latonz mentioned this pull request Aug 3, 2024
Open
@latonz
Copy link
Contributor

latonz commented Aug 3, 2024

Rel. #1406

@trejjam
Add UseExternalMapperFromAnotherAssembly which shut down Automapper i…
48b4237 
…n IDE
@trejjam
Use ProjectToTarget
0cc505d
@trejjam
Add UseStaticGenericMapperStaticMethodFromAnotherAssembly
98b7891
@trejjam
Simplify DateTimeMapper
e99d059
@trejjam
Support CompilationReference dependency
c2007d8
@trejjam
Add CompilationReference
a792741
@trejjam
Add SimpleMappingBuilderContext.GetSemanticModel
4df58cb
@trejjam
Use SimpleMappingBuilderContext.GetSemanticModel
eb08f28
@trejjam
Update UseStaticGenericMapperStaticMethodFromAnotherAssembly
5cbef3f
@trejjam
Update MapperGenerator
cebd2f4
@trejjam
Add SyntaxProvider.GetNestedCompilations
007ff32
@trejjam
Drop Riok.Mapperly.TestDependency
5224b4e
@trejjam
Add GetMetadataReferencesProvider
5065644
@trejjam
Use block body
2b1c019
@trejjam
Add OfType(IncrementalValuesProvider)
4a49bbd
@trejjam
Separate test into UseStaticGenericMapperStaticMethodFromAnotherAssem…
1906725 
…blyAsReference, UseStaticGenericMapperStaticMethodFromAnotherAssemblyAsCompiledAssembly
@trejjam
Add summary to tests
38df7f2
@trejjam trejjam force-pushed the feature/failing-projection-with-static-mapper-from-another-assembly branch from cebeb9a to 38df7f2 Compare August 3, 2024 09:51
@trejjam trejjam requested a review from latonz August 3, 2024 10:01
@latonz latonz enabled auto-merge (squash) August 3, 2024 14:35
@latonz latonz merged commit 6e7ab62 into riok:main Aug 3, 2024
17 checks passed
@trejjam trejjam deleted the feature/failing-projection-with-static-mapper-from-another-assembly branch August 4, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latonz latonz latonz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trejjam @latonz