chore: refactor Ref to Symbol #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonbyte
commented
Jan 7, 2024
wonbyte
changed the title
leostera
reviewed
Jan 7, 2024
|
Hi @wonbyte! Thanks for the PR ✨ – it looks good :) we just gotta export this new symbol module through Btw, the PR description triggered my AI spidey sense – is it AI? |
|
I did run it through some grammar and spell checking so nice catch 🕷️sense! I want to make sure I properly document everything as clearly as possible. Not sure i fully understand yet! I'll make those updates shortly. |
leostera
force-pushed
the
main
branch
2 times, most recently
from
7179093
to
b1364dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the role of
Refin handling unique identifiers and ensuring type safety, renamingReftoSymbolseems appropriate. The term "symbol" more accurately reflects its purpose and usage in the codebase.This work addresses #32