Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for es6 "import" #71

Merged
merged 4 commits into from Jun 11, 2016
Merged

Added support for es6 "import" #71

merged 4 commits into from Jun 11, 2016

Conversation

kuashe
Copy link
Contributor

@kuashe kuashe commented Jun 9, 2016

Added support for es6 "import"

Added support for es6 "import"
Fixed various errors from eslint
@coveralls
Copy link

coveralls commented Jun 9, 2016

Coverage Status

Coverage decreased (-0.2%) to 99.791% when pulling fa2f553 on kuashe:dev into 3d0987f on riot:dev.

@kuashe
Copy link
Contributor Author

kuashe commented Jun 9, 2016

@GianlucaGuarini @aMarCruz Please check it . How do I solve code coverage decrease ?

@@ -1080,7 +1115,7 @@ function compile (src, opts, url) {
}

// replace the tag with a call to the riot.tag2 function and we are done
return mktag(tagName, html, styles, attribs, jscode, opts)
return mktag(tagName, html, styles, attribs, jscode, opts, imports)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aMarCruz maybe we can use an option object here.. there are too many arguments here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also prefer to have the opts object always as last argument. Could you please fix it @kuashe ?

@GianlucaGuarini
Copy link
Member

@aMarCruz please verify this pull request and we can release the riot-compiler@2.5.0

@coveralls
Copy link

coveralls commented Jun 11, 2016

Coverage Status

Coverage decreased (-0.2%) to 99.791% when pulling 520d0f5 on kuashe:dev into 3d0987f on riot:dev.

@GianlucaGuarini GianlucaGuarini merged commit 7e6c56d into riot:dev Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants