Added support for es6 "import" #71

Merged
merged 4 commits into from Jun 11, 2016

Projects

None yet

3 participants

@kuashe
Contributor
kuashe commented Jun 9, 2016

Added support for es6 "import"

kuashe added some commits Jun 9, 2016
@kuashe kuashe Added support for es6 "import"
Added support for es6 "import"
205feaf
@kuashe kuashe Fixed eslint
Fixed various errors from eslint
fa2f553
@coveralls
coveralls commented Jun 9, 2016 edited

Coverage Status

Coverage decreased (-0.2%) to 99.791% when pulling fa2f553 on kuashe:dev into 3d0987f on riot:dev.

@kuashe
Contributor
kuashe commented Jun 9, 2016

@GianlucaGuarini @aMarCruz Please check it . How do I solve code coverage decrease ?

@GianlucaGuarini GianlucaGuarini commented on an outdated diff Jun 10, 2016
@@ -1080,7 +1115,7 @@ function compile (src, opts, url) {
}
// replace the tag with a call to the riot.tag2 function and we are done
- return mktag(tagName, html, styles, attribs, jscode, opts)
+ return mktag(tagName, html, styles, attribs, jscode, opts, imports)
@GianlucaGuarini
GianlucaGuarini Jun 10, 2016 Member

@aMarCruz maybe we can use an option object here.. there are too many arguments here

@GianlucaGuarini
GianlucaGuarini Jun 11, 2016 Member

I would also prefer to have the opts object always as last argument. Could you please fix it @kuashe ?

@GianlucaGuarini
Member

@aMarCruz please verify this pull request and we can release the riot-compiler@2.5.0

kuashe added some commits Jun 11, 2016
@kuashe kuashe Changed "mktag" argument order
Changed the maketag argument order
6fd5108
@kuashe kuashe Reorder JsDoc correctly
520d0f5
@coveralls
coveralls commented Jun 11, 2016 edited

Coverage Status

Coverage decreased (-0.2%) to 99.791% when pulling 520d0f5 on kuashe:dev into 3d0987f on riot:dev.

@GianlucaGuarini GianlucaGuarini merged commit 7e6c56d into riot:dev Jun 11, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 99.791%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment