New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for es6 "import" #71
Conversation
Added support for es6 "import"
Fixed various errors from eslint
@GianlucaGuarini @aMarCruz Please check it . How do I solve code coverage decrease ? |
@@ -1080,7 +1115,7 @@ function compile (src, opts, url) { | |||
} | |||
|
|||
// replace the tag with a call to the riot.tag2 function and we are done | |||
return mktag(tagName, html, styles, attribs, jscode, opts) | |||
return mktag(tagName, html, styles, attribs, jscode, opts, imports) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aMarCruz maybe we can use an option object here.. there are too many arguments here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also prefer to have the opts object always as last argument. Could you please fix it @kuashe ?
@aMarCruz please verify this pull request and we can release the riot-compiler@2.5.0 |
Changed the maketag argument order
Added support for es6 "import"