added: riot.settings.autoUpdate option closes #2377

riot · Jun 7, 2017 · 1a9259b · 1a9259b
1 parent 486e520
commit 1a9259b
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 4 deletions.
diff --git a/lib/browser/tag/if.js b/lib/browser/tag/if.js
@@ -1,4 +1,4 @@
-import { remAttr } from './../common/util/dom'
+import { remAttr, createDOMPlaceholder } from './../common/util/dom'
 import { tmpl } from 'riot-tmpl'
 import { unmountAll } from './../common/util/tags'
 import { CONDITIONAL_DIRECTIVE } from './../common/global-variables'
@@ -10,7 +10,7 @@ export default {
     remAttr(dom, CONDITIONAL_DIRECTIVE)
     this.tag = tag
     this.expr = expr
-    this.stub = document.createTextNode('')
+    this.stub = createDOMPlaceholder()
     this.pristine = dom
 
     var p = dom.parentNode

diff --git a/lib/browser/tag/setEventHandler.js b/lib/browser/tag/setEventHandler.js
@@ -2,6 +2,7 @@ import { isWritable } from './../common/util/check'
 import { contains } from './../common/util/misc'
 import { RE_EVENTS_PREFIX, RIOT_EVENTS_KEY } from '../common/global-variables'
 import { getImmediateCustomParentTag } from './../common/util/tags'
+import settings from '../../settings'
 
 /**
  * Trigger DOM events
@@ -31,6 +32,9 @@ function handleEvent(dom, handler, e) {
 
   handler.call(this, e)
 
+  // avoid auto updates
+  if (!settings.autoUpdate) return
+
   if (!e.preventUpdate) {
     var p = getImmediateCustomParentTag(this)
     // fixes #2083

diff --git a/lib/settings.js b/lib/settings.js
@@ -2,5 +2,7 @@ import { extend }from './browser/common/util/misc'
 import { brackets } from 'riot-tmpl'
 
 export default extend(Object.create(brackets.settings), {
-  skipAnonymousTags: true
+  skipAnonymousTags: true,
+  // handle the auto updates on any DOM event
+  autoUpdate: true
 })
diff --git a/test/specs/browser/riot/core.spec.js b/test/specs/browser/riot/core.spec.js
@@ -630,7 +630,7 @@ describe('Riot core', function() {
 
     expect(tag.refs['fancy-name'].innerHTML).to.be.equal('john')
 
-    fireEvent($$('p')[0], 'click', tag.root)
+    fireEvent($$('p')[0], 'click')
 
     expect(tag.refs['fancy-name'].innerHTML).to.be.equal('john')
 
@@ -1449,4 +1449,27 @@ describe('Riot core', function() {
     tag.unmount()
     document.body.removeChild(window.tmpsvg)
   })
+
+  it('disable the auto updates via settings.autoUpdate = false', function() {
+    injectHTML('<riot-tmp></riot-tmp>')
+
+    riot.tag('riot-tmp', '<p ref="p" onclick="{ updateMessage }">{ message }</p>', function() {
+      this.message = 'hi'
+      this.updateMessage = function() {
+        this.message = 'goodbye'
+      }
+    })
+
+    riot.settings.autoUpdate = false
+    var tag = riot.mount('riot-tmp')[0]
+
+    expect(tag.refs.p.innerHTML).to.be.equal(tag.message)
+
+    fireEvent(tag.refs.p, 'click')
+
+    expect(tag.refs.p.innerHTML).to.be.not.equal(tag.message)
+
+    tag.unmount()
+    riot.settings.autoUpdate = true
+  })
 })