Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I use the 'value' attribute with the custom tag? #2103

Closed
syuilo opened this issue Nov 27, 2016 · 2 comments
Closed

Can I use the 'value' attribute with the custom tag? #2103

syuilo opened this issue Nov 27, 2016 · 2 comments
Labels
bug

Comments

@syuilo
Copy link
Contributor

@syuilo syuilo commented Nov 27, 2016

<my-number value={ 12345 }></my-number>
<my-number>
  this.on('mount', () => {
    console.log(this.opts.value) // <= undefined
  })
</my-number>

Probably related to: #1618

How would you tag this issue?

  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@cognitom
Copy link
Member

@cognitom cognitom commented Nov 27, 2016

@syuilo yeah, it should be. Thanks for reporting! It seems a bug.

I've made a plunker here:
http://plnkr.co/edit/SBUYNYaQ9l9h6Cl58ZO1?p=preview

@cognitom cognitom removed the to verify label Nov 27, 2016
GianlucaGuarini added a commit that referenced this issue Mar 26, 2017
* master:
  updated: fixed wrong text in the readme file
  updated: libraries sizes
  3.4.0
  added: support for style and class object attributes
  closes #2178
  updated: simplified the special expressions updates
  updated: cleaning up the update method
  updated: dbmon frames rendering strategy
  closes #2080
  closes #2103
  fixed: make sure that the riot version gets exported as string
  updated: dev dependencies
  Enable syntax highlighting of tag files
  updated: small optimization avoiding the shouldUpdate check for the anonymous tags
  updated: dev dependencies
  Delete a duplicate line
@bonpixel
Copy link

@bonpixel bonpixel commented Apr 4, 2017

@GianlucaGuarini
This seems to still be broken for nested components:
http://plnkr.co/edit/AH8RcPEAUYPU7WM84jJP?p=preview

Works for <my-tag> but <my-other-tag> is still getting riotValue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.