This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
[TASK] Trade: Order flow eliminates unnecessary step (RT-3279) #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[TEST] make Sauce Labs tests work
[TASK] Usd: Drop cash option in deposit (RT-3218)
Change links to SnapSwap, btc2ripple - delete extra #
[FIX] XRP's name to Ripples and add STR
[FIX] Send: stop pathfinding on error-quote (RT-3201)
[TASK] Replace home-brewed rp-errors directives with ng-messages (RT-3191)
to use encrypt funded users username to variable FUNDED_USER_NAME and password to FUNDED_USER_PASSWORD and put to .travis.yml use as in LoginPrivate.json
[FIX] Resend email without unlock (RT-3104)
[TASK] gitignore: add angular-messages
[TASK] Remove cache bust
if popover is not used, do not create popover, and make only one interaction with dom - add one 'mouseenter' handler
fix rpAddressPopover
[FIX] Gruntfile: fix the watch
[FIX] Lock username after submit (RT-3084)
Fixed background attachment makes the scrolling laggy
[FIX] Show partial payments correctly (RT-1974)
Landing page performance and UI improvements
[FIX] Remove ticker wrapper on landing page
[TASK] Fix network status popup (RT-3297)
[TASK] Trust UI: popover shows -0.00 (RT-3267)
…-fix [FIX] Trust: use Amount's public api
[TASK] register page ripple name popup (RT-3194)
[TASK] Advanced: Add defaultripple flag option on settings (RT-3264)
[FIX] History: Remove trailing slash from historyApi url (RT-3268)
[FIX] Fund BTC: update the connected status (RT-3296)
[FIX] maxFee: save settings to userBlob (RT-3289)
[TASK] Trade: Remove hide function from orderbook (RT-3276)
[FIX] Calculate reserve in client
[TASK] Update ripple-lib
[TASK] Adapt to ripple-lib Amount changes
[TASK] Send: disallowXRP flag should only be notice (RT-3284)
[FIX] Link 'add gateway' to fund page (RT-3285)
…t setting on incoming trustline (RT-3240), fix outgoing trust showing as incoming (RT-3306)
[FEATURE] Trust: Allow edit incoming trustline (RT-3246), enable limit setting on incoming trustline (RT-3240), fix outgoing trust showing as incoming (RT-3306)
-switch to reload when fee changes
[FIX] Server status icon
| if (!modifying) order.mode = 'done'; | ||
|
|
||
| $timeout(function() { |
There was a problem hiding this comment.
What is this timeout for? Does it reset the form after 2 seconds? What if I started typing another offer?
There was a problem hiding this comment.
No, the notification goes away after 2 seconds. The form is not displayed until 2 seconds.
There was a problem hiding this comment.
@yongsoo why not? can we show both form and the notification?
There was a problem hiding this comment.
@vhpoet Maybe not good to move the buy/sell module (when notification screen goes away). Should we move this notification somewhere so it doesn't move the modules?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.