This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
Refactoring install commands into install phase #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FEATURE] Highlight new/changed orders (RT-3278)
[FIX] incoming trust line fix (RT-3392)
[TEST] really turn off custom gateways tests
Fix trade pairs order edit. Update ng-sortable to latest version.
[TASK] Remove sign up
[FIX] Fix trade pairs edit (RT-3343)
[TASK] Show login on first login
[TASK] Update announcement
[TASK] Update announcement
take into account case when there is no transaction in RippleState node
[FIX] fix json rewriter
[FIX] Background image and button breakpoint
[TASK] Add mixpanel tracking on migrate button
[FIX] Design changes on RT landing page
[FIX] Typo in announcement
[FIX] Wording in announcement
[FIX] Migrate to gatehub link
[TASK] Update announcement banner (RT-3581)
[FIX] Typo in announcement banner
[FEATURE] TravelRule: Move gateway address check to RTB
redredgroovy
force-pushed
the
develop
branch
3 times, most recently
from
5a8046b
to
dc6dbb4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having install commands in other phases violates the semantics of the
.travis.ymlconfiguration. So we have refactored them into theinstallphase.If the
installphase is not defined in the.travis.yml, Travis CI runsnpm installfor Node.js projects by default, as explained in the Travis CI docs here. To preserve that original behaviour after refactoring, we have added thenpm installcommand as well.Note: This pull request was generated by an automated tool developed by The Software REBELs (a.k.a., the Software Repository Excavation and Build Engineering Labs) of McGill University, Canada. It is part of a research project by Keheliya Gallaba under the supervision of Dr.Shane McIntosh. If you have any questions or feedback about this tool, please feel free to contact the author (keheliya.gallaba@mail.mcgill.ca).