This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
Use asyncify to remove callbacks on synchronous functions #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,10 +74,31 @@ var AccountSetResponseFlags = { | |||
| value: ripple.Transaction.flags.AccountSet.DisallowXRP} | |||
| }; | |||
|
|
|||
| var OfferCreateFlags = { | |||
There was a problem hiding this comment.
Should this be part of this commit?
|
This looks good to me, but I would appreciate if the commit message mentions updating a dependency and adding a new one (https://github.com/lydell/simple-asyncify) with maybe an example of how it's useful |
|
LGTM |
…-asyncify dependency, and update async dependency version
clark800
added a commit
that referenced
this pull request
Apr 22, 2015
Use asyncify to remove callbacks on synchronous functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.