Skip to content

Commit

Permalink
remove duplicate code in views
Browse files Browse the repository at this point in the history
  • Loading branch information
jkt3000 authored and Tobias Lütke committed Oct 31, 2009
1 parent 4cd20c4 commit e81f2f5
Showing 1 changed file with 4 additions and 14 deletions.
18 changes: 4 additions & 14 deletions server.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,12 @@
module GrepRenderer
attr_accessor :response, :parser, :marker, :params

def detect_parser(line)
shop_parser = ShopParser.new
hostname_parser = HostnameParser.new(shop_parser)
parser = TimeParser.new(hostname_parser, @params)
parser
end

def parser
@parser ||= TimeParser.new( HostnameParser.new(ShopParser.new), @params)
end

def detect_renderer(parser)
ShopifyLogRenderer.new
def renderer
@renderer ||= LogRenderer.new
end

# once download is complete, send it to client
Expand All @@ -51,11 +44,8 @@ def receive_data(data)

html = ""
while line = @buffer.scan_until(/\n/)
@renderer ||= detect_renderer(parser) unless @renderer # base render based on the parser


out = @renderer.render( parser.parse(line) )
html << out
tokens = parser.parse(line)
html << renderer.render(tokens)
end
return if html.empty?

Expand Down

0 comments on commit e81f2f5

Please sign in to comment.