Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags using handlebars, update styles #37

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

josuebran
Copy link
Contributor

@josuebran josuebran commented Oct 27, 2023

Content Rail

Tags

Tags are now using handlebars with the following page attribute
page-tags: Astra, ML, SDK, ...

Tags are rendered as span elements at this time and can be changed to anchor elements in the future.

datastax-content-rail-tags

Styling

Update headers, text styles and colors with figma

@mlr
Copy link
Contributor

mlr commented Oct 27, 2023

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Oct 27, 2023

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@@ -0,0 +1,10 @@
'use strict'

module.exports = (val) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice helper function! I think one improvement could be the ability to pass the split character/string as the second argument in case we want to split on something else.

Something like (val, char) => { and then val.split(char)

<h3>Tags</h3>
<div>
{{#each (split page.attributes.tags) }}
<span>{{this}}</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to have a class on these spans, <span class="span">

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops I typoed, I meant class="tag"

@mlr
Copy link
Contributor

mlr commented Oct 31, 2023

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Oct 31, 2023

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

Copy link
Collaborator

@colegoldsmith colegoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making those changes

@josuebran josuebran merged commit dafd3ad into main Nov 6, 2023
2 checks passed
@josuebran josuebran deleted the content-rail-styling branch November 8, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants