-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing guidelines #9
Conversation
josuebran
commented
Sep 19, 2023
- Set spacing system to 8px base unit
- Based on helios spacing system as specified
- Added css custom properties for spacing system
src/css/ds-button.css
Outdated
@@ -2,7 +2,7 @@ | |||
border-radius: 6px; | |||
padding: 0 12px; | |||
height: 40px; | |||
font-size: 0.90625rem; | |||
font-size: 1.8125rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is right, from the specs and using the --rem-base it should be font-size: calc(16 / var(--rem-base) * 1rem);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I will double check this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!