Update to 0.21 #89
Update to 0.21 #89
Conversation
capossele
commented
Mar 11, 2024
•
capossele
commented
- Update risc0 to 0.21
- Update risc0-eteherum to Update to risc0 0.21 risc0-ethereum#38
.github/workflows/main.yml
Outdated
| - name: Install cargo-install | ||
| uses: risc0/cargo-install@v1 | ||
| with: | ||
| crate: cargo-binstall | ||
|
|
||
| - name: Cargo binstall cargo-risczero | ||
| run: cargo binstall -y --force cargo-risczero@${{ env.RISC0_CRATE_VERSION }} | ||
| - name: Cargo install cargo-risczero | ||
| run: cargo install --force --locked cargo-risczero@$RISC0_CRATE_VERSION |
There was a problem hiding this comment.
IIUC, this will take quite a bit longer than installing and using binstall because it'll require building the prover, which is quite slow at the moment. Is there a particular reason to do it this way instead?
.github/workflows/main.yml
Outdated
| - run: sccache --show-stats | ||
|
|
There was a problem hiding this comment.
I don't think sccache is installed/initialized in this workflow right now. My thought on not including it is that we expect folks to clone/fork this repo and the likely host their code on GitHub. When they do, we'd like it to be simple for them to enable GitHub actions based CI. In that flow, sccache adds some friction as we've had to do quite a bit of work to get it running smoothly (but maybe I am overstating how much friction we've experienced)
| - run: sccache --show-stats |
.github/workflows/main.yml
Outdated
| - name: Install cargo-install | ||
| uses: risc0/cargo-install@v1 | ||
| with: | ||
| crate: cargo-binstall | ||
|
|
||
| - name: Cargo binstall cargo-risczero | ||
| run: cargo binstall -y --force cargo-risczero@${{ env.RISC0_CRATE_VERSION }} | ||
| - name: Cargo install cargo-risczero | ||
| run: cargo install --force --locked cargo-risczero@$RISC0_CRATE_VERSION |
Cargo.toml
Outdated
| @@ -12,19 +12,17 @@ alloy-primitives = { version = "0.6", default-features = false, features = ["rlp | |||
| alloy-sol-types = { version = "0.6" } | |||
| anyhow = { version = "1.0.75" } | |||
| bincode = { version = "1.3" } | |||
| bonsai-sdk = { version = "0.6.1" } | |||
| bonsai-sdk = { git = "https://github.com/risc0/risc0", branch = "release-0.21" } | |||
There was a problem hiding this comment.
Should this be a version ref, matching the one in risc0-ethereum?
