Integrate risc0-ethereum on CI
#1525
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Converting to draft until we fix one small issue after some introduced changes |
capossele
force-pushed
the
capossele/risc0-ethereum-CI
branch
from
3df040d
to
ba6a787
Compare
|
We got a green light for an integration test against a modified branch of risc0-ethereum and bonsai-foundry-template here: https://github.com/risc0/risc0/actions/runs/8327243926/job/22784515671?pr=1525 |
| // When running a new ceremony, update them by running cargo xtask bootstrap-groth16. | ||
| // Constants from: risc0-ethereum/contracts/src/groth16/Groth16Verifier.sol | ||
| // When running a new ceremony, update them by running cargo xtask bootstrap-groth16 | ||
| // after udpating the new Groth16Verifier.sol on the risc0-ethereum repo. |
There was a problem hiding this comment.
Maybe a future improvement of this will be to save each ID to a file so we can update them more easily by running the bootstrap command rather than copy/paste. we could do include_str!(file); where file contains the id's themselves that get updated. I know a few places where we could do something like this like the reproducible build workflow so we could pile them up into a single gh issue.
There was a problem hiding this comment.
btw - no action needed on this, I'm just thinking out loud
| env: | ||
| RUST_BACKTRACE: full | ||
| steps: | ||
| # This is a workaround from: https://github.com/actions/checkout/issues/590#issuecomment-970586842 |
There was a problem hiding this comment.
This is another comment, no action needed at this time: so now that we don't have any sub-modules in risc0, we could consider dropping this workaround. We can still keep it around though
Co-authored-by: Victor Graf <victor@risczero.com>
risc0-ethereumown repoxtask bootstrap-groth16tool to work with the externalrisc0-ethereumreporisc0-ethereumandbonsai-foundry-template). The patching is done via a python script rather than withCargo patchas it is more flexible, allowing to also patch git submodule dependencies without requiring any changes on the external repos.These checks also include checking the Solidity verifier (on
risc0-ethereum) against a Groth16 receipt generated from therisc0repo.risc0-ethereumbonsai-foundry-templateTODO:
capossele/risc0-CIbranch once we land the required changes on risc0-ethereum #38 and bonsai-foundry-template #89move the governance example toadjust its website's related links temporarly to 0.20 branchrisc0-ethereumandResolves: https://github.com/risc0/scratch/issues/270
Resolves: #1406