-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to risc0 0.21 #38
Conversation
Cargo.toml
Outdated
bonsai-rest-api-mock = { git = "https://github.com/risc0/risc0", branch = "release-0.21", default-features = false } | ||
bonsai-sdk = { git = "https://github.com/risc0/risc0", branch = "release-0.21", default-features = false } | ||
risc0-build = { git = "https://github.com/risc0/risc0", branch = "release-0.21", default-features = false } | ||
risc0-zkp = { git = "https://github.com/risc0/risc0", branch = "release-0.21", default-features = false } | ||
risc0-zkvm = { git = "https://github.com/risc0/risc0", branch = "release-0.21", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are git
references, we can't publish the crates to crates.io
. We haven't started doing that yet, but we may. Is there a reason to use git
vs version? If so, this seems fine. If not, we might want to use version instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this pr is not for the release but for main, I thought to keep the branch as it gets all the updates rather than the version (that instead should be used for the release). Also, bonsai-rest-api-mock
has been dropped from the published crates on risc0, so we don't have a published updated version for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference I think is to use crates.io
here, unless we need unpublished crates (e.g. using a git
reference for bonsai-api-mock
, which is a dev dependency seems fine). It doesn't seem, to me, to add value to use git
references here, but it does add a step to the release process when we need to change all of these references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But happy to disagree and commit here. Up to you.
@@ -15,7 +15,7 @@ | |||
use alloy_primitives::U256; | |||
use alloy_sol_types::{sol, SolValue}; | |||
use anyhow::{ensure, Result}; | |||
use bonsai_sdk::alpha as bonsai_sdk; | |||
use risc0_zkvm::Groth16Seal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooo, I'm happy to see this 🎉
89d190b
to
2f5f4e9
Compare
risc0-ethereum
. This is useful when automatising the patch on cross-repo CI.bonsai-rest-api-mock
fromrisc0
Closes #39