Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download(risc0-circuit-recursion-70bfa09004bfe688/out/recursion_zkr.zip: (verification: unverified) #1163

Closed
GopherJ opened this issue Nov 23, 2023 · 6 comments · Fixed by #1367
Closed

Download(risc0-circuit-recursion-70bfa09004bfe688/out/recursion_zkr.zip: (verification: unverified) #1163

GopherJ opened this issue Nov 23, 2023 · 6 comments · Fixed by #1367
Assignees
@flaub
Milestone
0.20.0

Comments

@GopherJ
Copy link

GopherJ commented Nov 23, 2023

No description provided.

@GopherJ
Copy link
Author

GopherJ commented Nov 23, 2023

this happened while running cargo check but it's fine in cargo build

@rahulghangas
Copy link

rahulghangas commented Nov 26, 2023 •
edited

Seeing the same on cargo run, only with bonsai

@ayg2002
Copy link

ayg2002 commented Nov 27, 2023

didn't work on my side as well

@SchmErik
Copy link
Contributor

this happened while running cargo check but it's fine in cargo build

Where are you running this on? The starter template? the risc0 repo?

@flaub flaub changed the title called Result::unwrap() on an Err value: Download(risc0-circuit-recursion-70bfa09004bfe688/out/recursion_zkr.zip: (verification: unverified): Download(risc0-circuit-recursion-70bfa09004bfe688/out/recursion_zkr.zip: (verification: unverified) Nov 29, 2023
@flaub flaub mentioned this issue Dec 1, 2023
Merged
@flaub flaub self-assigned this Dec 1, 2023
@flaub flaub added this to the 0.20.0 milestone Dec 1, 2023
@flaub
Copy link
Member

flaub commented Dec 4, 2023

I think we have a fix for this that will be ready in the next release: #1184

@neysofu neysofu mentioned this issue Jan 16, 2024
Merged
@flaub
Copy link
Member

flaub commented Jan 23, 2024

A better fix is here: #1367

@flaub flaub mentioned this issue Jan 23, 2024
Merged
@flaub flaub closed this as completed in 496b2a0 Jan 23, 2024
flaub added a commit that referenced this issue Jan 24, 2024
@flaub
Improve handling of recursion_zkr.zip (#1367)
d0b1d8a 
* Avoid re-downloading if cached copy is already valid
* Copy source from LFS only if file is valid (i.e. LFS has been pulled)
* Download from S3 bucket otherwise
* Update hash to latest
* Fix docs.rs build issue
* Fixes #1366
* Fixes #1048
* Supersedes #1347
* Supersedes #1348
* Fixes #1163

Co-authored-by: @weikengchen
flaub added a commit that referenced this issue Jan 24, 2024
@flaub
Improve handling of recursion_zkr.zip (#1367)
0c8cc23 
* Avoid re-downloading if cached copy is already valid
* Copy source from LFS only if file is valid (i.e. LFS has been pulled)
* Download from S3 bucket otherwise
* Update hash to latest
* Fix docs.rs build issue
* Fixes #1366
* Fixes #1048
* Supersedes #1347
* Supersedes #1348
* Fixes #1163

Co-authored-by: @weikengchen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaub flaub

Labels
None yet
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

Improve handling of recursion_zkr.zip risc0/risc0
5 participants
@flaub @SchmErik @rahulghangas @GopherJ @ayg2002