Composition fails to resolve assumption in the client/server API

[rlukata]

Report

Composition fails with value: sys_verify_integrity: failed to resolve journal_digest and image_id when used with client/server API.

Steps to Reproduce

1. Cargo.toml

risc0-zkvm = { workspace = true, features = ["client"] }

2. In the host:

let env = ExecutorEnv::builder()
        .add_assumption(receipt.clone().into())
        .write(&compute_image_id(METHOD_NAME_ELF)?)?
        .write(&receipt.journal.bytes)?
        .build()
        .unwrap();
let exec = default_executor();
let session = exec.execute(env, METHOD_NAME_ELF).unwrap();

3. In the guest:

let image_id: Digest = env::read();
let journal: Vec<u8> = env::read();
env::verify(image_id, &journal).unwrap();

Expected behavior

The verify should pass.

Your Environment

• risc0-zkvm version: 0.20.1 alpha
• Rust version: 1.72.1
• Platform/OS: M2 MacOS

[nategraf]

I've confirmed that I forgot to add assumptions to the protobuf definition of ExecutorEnv and so assumptions are not transferred from client to server 🤦‍♂️ .

risc0/risc0/zkvm/src/host/api/client.rs

Lines 326 to 347 in 05f46ef

	fn make_execute_env(
	&self,
	env: &ExecutorEnv<'_>,
	binary: pb::api::Asset,
	) -> pb::api::ExecutorEnv {
	pb::api::ExecutorEnv {
	binary: Some(binary),
	env_vars: env.env_vars.clone(),
	args: env.args.clone(),
	slice_ios: env.slice_io.borrow().inner.keys().cloned().collect(),
	read_fds: env.posix_io.borrow().read_fds.keys().cloned().collect(),
	write_fds: env.posix_io.borrow().write_fds.keys().cloned().collect(),
	segment_limit_po2: env.segment_limit_po2,
	session_limit: env.session_limit,
	trace_events: (!env.trace.is_empty()).then_some(()),
	pprof_out: env
	.pprof_out
	.as_ref()
	.map(|x| x.to_string_lossy().into())
	.unwrap_or_default(),
	}
	}

Working on adding assumptions to the protobuf types and fixing this now

[nategraf]

Deleted the "[Enhancement]" from the tittle since we have tags to indicate what type of issue this is