Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proof of fault #1307

Closed
SchmErik opened this issue Jan 9, 2024 · 0 comments · Fixed by #1341
Closed

Remove proof of fault #1307

SchmErik opened this issue Jan 9, 2024 · 0 comments · Fixed by #1341
Assignees
@SchmErik
Labels
enhancement New feature or request

Comments

@SchmErik
Copy link
Contributor

SchmErik commented Jan 9, 2024

Bug Report

Proof of fault will be removed from the zkVM. We'll implement this as in a future implementation of the circuit.

Things to remove:

  1. fault checker guest code
  2. remove fault-proof feature flag
  3. remove ExitCode::Fault code paths in executor and return an error instead.

Other notes:

Let's remove this after we root-cause #1306
@SchmErik SchmErik added bug Something isn't working duplicate This issue or pull request already exists enhancement New feature or request and removed bug Something isn't working duplicate This issue or pull request already exists labels Jan 9, 2024
@SchmErik SchmErik mentioned this issue Jan 17, 2024
Merged
@SchmErik SchmErik self-assigned this Jan 18, 2024
SchmErik added a commit that referenced this issue Jan 22, 2024
@SchmErik
zkVM: remove proof of fault (#1341)
b1598cf 
Proof of fault is a mechanism that allows receipt generation for
programs that fail due to incorrect RISC-V execution and other
conditions. We're removing this feature for the time being and plan to
implement this in a future circuit revision.

This change removes the fault checker guest code, the `fault-proof`
feature flag, the `bootstrap-fault` command from `cargo xtask`, and
removes `ExitCode::Fault` and marks this as reserved in base.proto.

Fixes: #1307
flaub pushed a commit that referenced this issue Jan 24, 2024
@SchmErik @flaub
zkVM: remove proof of fault (#1341)
797a809 
Proof of fault is a mechanism that allows receipt generation for
programs that fail due to incorrect RISC-V execution and other
conditions. We're removing this feature for the time being and plan to
implement this in a future circuit revision.

This change removes the fault checker guest code, the `fault-proof`
feature flag, the `bootstrap-fault` command from `cargo xtask`, and
removes `ExitCode::Fault` and marks this as reserved in base.proto.

Fixes: #1307
flaub pushed a commit that referenced this issue Jan 24, 2024
@SchmErik @flaub
zkVM: remove proof of fault (#1341)
d9d4f8c 
Proof of fault is a mechanism that allows receipt generation for
programs that fail due to incorrect RISC-V execution and other
conditions. We're removing this feature for the time being and plan to
implement this in a future circuit revision.

This change removes the fault checker guest code, the `fault-proof`
feature flag, the `bootstrap-fault` command from `cargo xtask`, and
removes `ExitCode::Fault` and marks this as reserved in base.proto.

Fixes: #1307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SchmErik SchmErik

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

zkVM: remove proof of fault risc0/risc0
1 participant
@SchmErik