Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs website updates #1070

Merged
merged 8 commits into from
Nov 2, 2023
Merged

docs website updates #1070

merged 8 commits into from
Nov 2, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Oct 31, 2023

  • Upgrade docusaurus to 3.0
  • Use multi-instance to split versioned from unversioned content
  • Split unversioned files into resources directory
  • Snap version 0.19

* Upgrade docusaurus to 3.0
* Use multi-instance to split versioned from unversioned content
* Split unversioned files into resources directory
* Snap version 0.19

TODO: add redirects for permalinks
@flaub flaub self-assigned this Oct 31, 2023
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 1:05am

Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm not sure if this is just a Vercel error, but it looks like the root page gives a 404 -- i.e., going to plain dev.risczero.com would return a 404, so perhaps something was lost in setting a "main" landing page.

@github-actions github-actions bot temporarily deployed to preview November 1, 2023 19:34 Destroyed
Copy link

github-actions bot commented Nov 1, 2023

Pages Preview
🚀 Deployed preview to https://risc0.github.io/website-preview/risc0/risc0/pr/1070
on branch gh-pages at 2023-11-01 23:46:53 +0000

Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the preview link still gives a 404, I think it may be an artifact of how it previews; it redirects from https://risc0.github.io/website-preview/risc0/risc0/pr/1070 to https://risc0.github.io/api, and the latter doesn't exist. However, https://risc0.github.io/website-preview/risc0/risc0/pr/1070/api does exist, and hopefully better models what this would act like in production.

@flaub
Copy link
Member Author

flaub commented Nov 1, 2023

Note that the Vercel preview does work as expected. It looks like the ghpages preview isn't being rebuilt on each push to the PR branch.

@github-actions github-actions bot temporarily deployed to preview November 1, 2023 23:41 Destroyed
@flaub flaub marked this pull request as ready for review November 1, 2023 23:45
@github-actions github-actions bot temporarily deployed to preview November 1, 2023 23:46 Destroyed
@flaub flaub disabled auto-merge November 2, 2023 01:23
@flaub flaub merged commit b0ac312 into main Nov 2, 2023
5 checks passed
@flaub flaub deleted the flaub/update-docs branch November 2, 2023 01:23
flaub added a commit that referenced this pull request Nov 8, 2023
* Upgrade docusaurus to 3.0
* Use multi-instance to split versioned from unversioned content
* Split unversioned files into resources directory
* Snap version 0.19
flaub added a commit that referenced this pull request Nov 8, 2023
* Upgrade docusaurus to 3.0
* Use multi-instance to split versioned from unversioned content
* Split unversioned files into resources directory
* Snap version 0.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants