Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture and forward server errors to clients #1096

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Capture and forward server errors to clients #1096

merged 1 commit into from
Nov 3, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Nov 3, 2023

Resolves #1093

@flaub flaub self-assigned this Nov 3, 2023
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 6:55am

@flaub flaub added this to the 0.19.1 milestone Nov 3, 2023
Copy link
Contributor

@mothran mothran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SchmErik SchmErik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! I'm not sure what in this PR is causing the benchmark check to fail though...

@SchmErik
Copy link
Contributor

SchmErik commented Nov 3, 2023

looks good to me! I'm not sure what in this PR is causing the benchmark check to fail though...

Oh, I'm assuming this is the broken benchmarks referenced by #1013

@flaub flaub merged commit a2016b8 into main Nov 3, 2023
21 of 22 checks passed
@flaub flaub deleted the flaub/fix-1093 branch November 3, 2023 18:10
flaub added a commit that referenced this pull request Nov 3, 2023
flaub added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r0vm failures (guests faults in Executor) should report rich error data to the Client.
3 participants