-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: restrict software ecall handler address range #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…address range Software ecalls should only send data from valid guest addresses. Restrict this by checking at the SyscallContext trait so all software ecall handlers exhibit this property.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
flaub
approved these changes
Nov 6, 2023
flaub
added a commit
that referenced
this pull request
Nov 8, 2023
Software ecalls should only send data from valid guest addresses. Restrict this by checking at the SyscallContext trait so all software ecall handlers exhibit this property. Fixes: risc0/risczero-wip#385 --------- Co-authored-by: Frank Laub <flaub@risc0.com>
flaub
added a commit
that referenced
this pull request
Nov 8, 2023
Software ecalls should only send data from valid guest addresses. Restrict this by checking at the SyscallContext trait so all software ecall handlers exhibit this property. Fixes: risc0/risczero-wip#385 --------- Co-authored-by: Frank Laub <flaub@risc0.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Software ecalls should only send data from valid guest addresses. Restrict this
by checking at the SyscallContext trait so all software ecall handlers exhibit
this property.
Fixes: https://github.com/risc0/risczero-wip/issues/385