Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: restrict software ecall handler address range #1102

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

SchmErik
Copy link
Contributor

@SchmErik SchmErik commented Nov 4, 2023

Software ecalls should only send data from valid guest addresses. Restrict this
by checking at the SyscallContext trait so all software ecall handlers exhibit
this property.

Fixes: https://github.com/risc0/risczero-wip/issues/385

…address range

Software ecalls should only send data from valid guest addresses. Restrict this
by checking at the SyscallContext trait so all software ecall handlers exhibit
this property.
@SchmErik SchmErik requested a review from flaub November 4, 2023 02:46
Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 3:45am

@flaub flaub disabled auto-merge November 7, 2023 04:31
@flaub flaub merged commit b1e46ab into main Nov 7, 2023
21 checks passed
@flaub flaub deleted the erik/soft-ecall-addr branch November 7, 2023 04:31
@flaub flaub modified the milestones: 0.20.0, 0.19.1 Nov 7, 2023
flaub added a commit that referenced this pull request Nov 8, 2023
Software ecalls should only send data from valid guest addresses.
Restrict this
by checking at the SyscallContext trait so all software ecall handlers
exhibit
this property.

Fixes: risc0/risczero-wip#385

---------

Co-authored-by: Frank Laub <flaub@risc0.com>
flaub added a commit that referenced this pull request Nov 8, 2023
Software ecalls should only send data from valid guest addresses.
Restrict this
by checking at the SyscallContext trait so all software ecall handlers
exhibit
this property.

Fixes: risc0/risczero-wip#385

---------

Co-authored-by: Frank Laub <flaub@risc0.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants