Fix a typo in guest-code-101.md regarding journal #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tzerrell
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Whoops! Good catch, you are correct!
This also needs to be fixed in the other versions of the docs (in website/api_versioned_docs/version-0.18/zkvm/developer-guide/guest-code-101.md and website/api/zkvm/developer-guide/guest-code-101.md) -- do you mind getting those changes as well? Or I can make a separate PR for those if needed.
|
@tzerrell Added those changes. |
|
Thank you for both finding this and fixing it! |
flaub
pushed a commit
that referenced
this pull request
Nov 8, 2023
It seems that journal is where we put the public outputs, rather than the private outputs, based on the contexts? This is an edit to guest-code-101.md.
flaub
pushed a commit
that referenced
this pull request
Nov 8, 2023
It seems that journal is where we put the public outputs, rather than the private outputs, based on the contexts? This is an edit to guest-code-101.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that journal is where we put the public outputs, rather than the private outputs, based on the contexts?
This is an edit to guest-code-101.md.